Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry peers if connection refused #8192

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Conversation

spylogsster
Copy link
Contributor

Resolves brave/brave-browser#14328

For some reason on mac the node started asynchronously and does not accept connections until it is initialized. Added retries to repeat requests few times, on my mac it takes ~ 1 second to be initialized and 3-4 retries

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • [] Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Same steps as in source issue

@spylogsster spylogsster force-pushed the ipfs-session-restore-osx branch 5 times, most recently from 40d2122 to 2751a22 Compare March 10, 2021 14:48
@spylogsster spylogsster force-pushed the ipfs-session-restore-osx branch 2 times, most recently from da826c0 to 6089c00 Compare March 10, 2021 15:39
@spylogsster spylogsster force-pushed the ipfs-session-restore-osx branch from 6089c00 to a88435b Compare March 10, 2021 17:18
@spylogsster spylogsster merged commit a9c6cdb into master Mar 10, 2021
@spylogsster spylogsster deleted the ipfs-session-restore-osx branch March 10, 2021 20:08
@spylogsster spylogsster added this to the 1.23.x - Nightly milestone Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPFS tabs (still) sometimes fail to reload in Session Restore
2 participants