Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated l10n for 1.21.x release (Chromium 89) - 1.21.x. #8097

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Mar 1, 2021

Fixes brave/brave-browser#14369
Uplift from #8093

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin requested a review from a team March 1, 2021 20:37
@mkarolin mkarolin requested a review from a team as a code owner March 1, 2021 20:37
@mkarolin mkarolin self-assigned this Mar 1, 2021
@mkarolin mkarolin requested review from emerick and zenparsing and removed request for a team March 1, 2021 20:37
@kjozwiak kjozwiak added this to the 1.21.x - Release milestone Mar 1, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Mar 1, 2021

audit-deps failed on post-init due to a known issue as per https://ci.brave.com/job/pr-brave-browser-maxk-cr89-l10n-1.21.x-post-init/1/execution/node/145/log/. Doesn't block uplift.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.21.x approved after deliberating with @brave/uplift-approvers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants