Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't show force_hide selectors on cosmetic filters iterations #8056

Merged
merged 1 commit into from
Feb 25, 2021
Merged

don't show force_hide selectors on cosmetic filters iterations #8056

merged 1 commit into from
Feb 25, 2021

Conversation

SergeyZhukovsky
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky commented Feb 24, 2021 •
edited by kjozwiak
Loading

Uplift of #8046
Resolves brave/brave-browser#14294

Submitter Checklist:

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@SergeyZhukovsky SergeyZhukovsky added this to the 1.21.x - Release milestone Feb 24, 2021
@SergeyZhukovsky SergeyZhukovsky requested a review from a team February 24, 2021 03:15
@SergeyZhukovsky SergeyZhukovsky self-assigned this Feb 24, 2021
@SergeyZhukovsky
Copy link
Member Author

post-init failed due to known audit failure, not related to the current PR

kjozwiak
kjozwiak approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.21.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #8046 (comment).

@kjozwiak kjozwiak merged commit 08f61a3 into 1.21.x Feb 25, 2021
@kjozwiak kjozwiak deleted the pr8046_force_hide_selectors_new1_uplift_1.21.x branch February 25, 2021 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@SergeyZhukovsky SergeyZhukovsky

Labels
None yet
Projects
None yet
Milestone
1.21.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@SergeyZhukovsky @kjozwiak