Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not start the ledger process when attempting to get publisher info (uplift to 1.20.x) #8045

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Do not start the ledger process when attempting to get publisher info (uplift to 1.20.x) #8045

merged 1 commit into from
Feb 23, 2021

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Feb 23, 2021 •
edited by kjozwiak
Loading

Uplift of #8036
Resolves brave/brave-browser#14307

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@zenparsing zenparsing added this to the 1.20.x - Release #3 milestone Feb 23, 2021
@zenparsing zenparsing requested a review from a team February 23, 2021 14:42
@zenparsing zenparsing requested review from tmancey and a team as code owners February 23, 2021 14:42
@zenparsing zenparsing requested review from emerick and removed request for a team February 23, 2021 14:42
kjozwiak
kjozwiak approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.20.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #8036 (comment).

@kjozwiak kjozwiak merged commit 97ff44e into 1.20.x Feb 23, 2021
@kjozwiak kjozwiak deleted the ksmith-rewards-chill-1.20 branch February 23, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@tmancey tmancey Awaiting requested review from tmancey tmancey is a code owner

@emerick emerick Awaiting requested review from emerick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.20.x - Release #3
Development

Successfully merging this pull request may close these issues.
2 participants
@zenparsing @kjozwiak