Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds applying of force_hide_selectors rules #8028

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

SergeyZhukovsky
Copy link
Member

Resolves brave/brave-browser#14294

Submitter Checklist:

  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)
  • Requested a security/privacy review as needed

Reviewer Checklist:

  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

It's described in the original issue

@SergeyZhukovsky
Copy link
Member Author

post-init failed due to audit, not related to the PR changes

@SergeyZhukovsky SergeyZhukovsky added this to the 1.22.x - Nightly milestone Feb 22, 2021
@SergeyZhukovsky SergeyZhukovsky merged commit ff6fff5 into master Feb 22, 2021
@SergeyZhukovsky SergeyZhukovsky deleted the force_hide_selectors branch February 22, 2021 18:59
brave-builds pushed a commit that referenced this pull request Feb 22, 2021
Copy link
Contributor

@pes10k pes10k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kjozwiak
Copy link
Member

kjozwiak commented Feb 23, 2021

@SergeyZhukovsky this seems like it's working on Android but doesn't seem to be working on Win 10 x64. Example:

Android Test Case - PASSED

1.22.39 CR: 89.0.4389.58 1.22.39 CR: 89.0.4389.58
Screenshot_20210222-204714_Brave - Nightly Screenshot_20210222-204720_Brave - Nightly
1.22.41 CR: 89.0.4389.58 1.22.41 CR: 89.0.4389.58
Screenshot_20210223-023404_Brave - Nightly Screenshot_20210223-023423_Brave - Nightly

Desktop Test Case - FAILED

image

@SergeyZhukovsky SergeyZhukovsky restored the force_hide_selectors branch February 23, 2021 16:07
@SergeyZhukovsky
Copy link
Member Author

@kjozwiak I found the problem and reopened the original issue, preparing another fix

@mihaiplesa mihaiplesa deleted the force_hide_selectors branch June 10, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosmetic Filters don't apply custom rules
4 participants