Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ipns and ifps as default handlers #7864

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Set ipns and ifps as default handlers #7864

merged 1 commit into from
Feb 11, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Feb 8, 2021

Resolves brave/brave-browser#13266

Brave registered in the host OS as a handler for ipfs: and ipns: URIs.

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Enable a local node
  • (On Windows): Press Win+R, type ipfs://bafkreigcnxudvpojjfwncmauociy5q46zsq46oe66cxbyzie3imabuoege, and press Enter
  • (On macOS): Open the Terminal, and type open ipfs://bafkreigcnxudvpojjfwncmauociy5q46zsq46oe66cxbyzie3imabuoege, and press Enter.
  • (On Linux): Open a shell and type xdg-open ipfs://bafkreigcnxudvpojjfwncmauociy5q46zsq46oe66cxbyzie3imabuoege
  • urls should be opened in Brave

@spylogsster spylogsster requested a review from bbondy February 8, 2021 14:24
@spylogsster spylogsster requested a review from a team as a code owner February 8, 2021 14:32
@spylogsster spylogsster force-pushed the protocol-associations branch 4 times, most recently from 0a47069 to 0a26a4f Compare February 8, 2021 15:25
@bbondy bbondy requested a review from diracdeltas February 8, 2021 15:29
@bbondy
Copy link
Member

bbondy commented Feb 8, 2021

I added a security review for this: https://github.com/brave/security/issues/303

@spylogsster spylogsster force-pushed the protocol-associations branch 4 times, most recently from dbc7a5c to 52d4f4e Compare February 10, 2021 18:44
@spylogsster spylogsster force-pushed the protocol-associations branch from 52d4f4e to a7f1d89 Compare February 10, 2021 18:46
@bbondy bbondy merged commit 2b7826e into master Feb 11, 2021
@bbondy bbondy deleted the protocol-associations branch February 11, 2021 20:00
@simonhong simonhong restored the protocol-associations branch February 12, 2021 00:43
@bbondy bbondy added this to the 1.22.x - Nightly milestone Feb 12, 2021
@mihaiplesa mihaiplesa deleted the protocol-associations branch June 10, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ipfs: and ipns: protocol associations
2 participants