Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry if no peers fetched #7818

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Retry if no peers fetched #7818

merged 1 commit into from
Feb 5, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Feb 4, 2021

13932: If no peers available at the moment when session restord
we have to retry fetching to load page when peers available.

Resolves brave/brave-browser#13932
Resolves brave/brave-browser#13177

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@spylogsster spylogsster changed the title Retry peers fetch if got zero value Retry if no peers fetched Feb 4, 2021
@spylogsster spylogsster force-pushed the zero-peers-fix branch 2 times, most recently from f4ca558 to 89165cc Compare February 4, 2021 09:45
@spylogsster spylogsster requested a review from bbondy February 4, 2021 16:12
13932: If no peers available at the moment when session restord
we have to retry fetching to load page when peers available.

cc
@spylogsster spylogsster merged commit 047fe09 into master Feb 5, 2021
@spylogsster spylogsster deleted the zero-peers-fix branch February 5, 2021 14:26
@spylogsster spylogsster added this to the 1.22.x - Nightly milestone Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants