Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated patches from Chromium 88.0.4324.96 to Chromium 88.0.4324.146 (1.20.x). #7794

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Feb 3, 2021

Fixes brave/brave-browser#13900
Related PR: brave/brave-browser#13914
Uplift from #7790

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Updated patches from Chromium 88.0.4324.96 to Chromium 88.0.4324.146.
@mkarolin mkarolin added the CI/run-network-audit Run network-audit label Feb 3, 2021
@mkarolin mkarolin requested a review from a team February 3, 2021 00:35
@mkarolin mkarolin requested review from samartnik and a team as code owners February 3, 2021 00:35
@mkarolin mkarolin self-assigned this Feb 3, 2021
@kjozwiak kjozwiak added this to the 1.20.x - Beta milestone Feb 3, 2021
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.20.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit db1613b into 1.20.x Feb 3, 2021
@kjozwiak kjozwiak deleted the 88.0.4324.146-1.20.x branch February 3, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants