Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes kVideoPlaybackQuality from disabled features. #7667

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

mkarolin
Copy link
Collaborator

This fixes an incorrect merge introduced by #7518 that
reverted the fix initially implemented by #7451.

Fixes brave/brave-browser#13679

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This fixes an incorrect merge introduced by #7518 that
reverted the fix initially implemented by #7451.

Fixes brave/brave-browser#13679
@mkarolin mkarolin requested a review from bsclifton January 20, 2021 14:51
@mkarolin mkarolin self-assigned this Jan 20, 2021
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄

@mkarolin
Copy link
Collaborator Author

CI: MacOS: a known browser test failure RewardsPromotionBrowserTest.ClaimViaPanel.

@mkarolin mkarolin merged commit dbfa8c1 into 1.19.x Jan 20, 2021
@mkarolin mkarolin deleted the maxk-fix-kVideoPlaybackQuality-1.19.x branch January 20, 2021 18:32
@kjozwiak kjozwiak added this to the 1.19.x - Release #2 milestone Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants