Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macOS app icons #7356

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Update macOS app icons #7356

merged 1 commit into from
Dec 8, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Dec 6, 2020

Resolves brave/brave-browser#13005

Screen Shot 2020-12-06 at 2 46 12 AM

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@simonhong simonhong requested a review from karenkliu December 6, 2020 00:59
@simonhong simonhong self-assigned this Dec 6, 2020
@simonhong simonhong force-pushed the update_macos_app_icons branch from f82833d to 5c6fed3 Compare December 6, 2020 01:00
@simonhong simonhong added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Dec 6, 2020
Copy link

@karenkliu karenkliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀 we need to see the icons in context with other app icons in the dock though to fully verify that they are the appropriate size.

@simonhong
Copy link
Member Author

@karenkliu it looks good :)
image

@karenkliu
Copy link

Yeah, it's a better size than before! 👍

@simonhong simonhong merged commit 2df3ef8 into master Dec 8, 2020
@simonhong simonhong deleted the update_macos_app_icons branch December 8, 2020 00:37
@simonhong simonhong added this to the 1.20.x - Nightly milestone Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update icons for macOS
2 participants