Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signature of function callback. #7320

Merged
merged 2 commits into from
Dec 3, 2020
Merged

Fix signature of function callback. #7320

merged 2 commits into from
Dec 3, 2020

Conversation

bsclifton
Copy link
Member

Fixes brave/brave-browser#12997

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bsclifton bsclifton self-assigned this Dec 2, 2020
@bsclifton bsclifton mentioned this pull request Dec 2, 2020
23 tasks
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ if iOS CI is green.

@bsclifton
Copy link
Member Author

Special thanks to @linhkikuchi for helping me troubleshoot CI problems 😄 We did a revert with https://github.com/brave/devops/pull/4056 (because it was using tags not branch) and verified that it passed

I rebased after recent Chromium upgrade; we should be good to merge after CI finishes here

@bsclifton
Copy link
Member Author

bsclifton commented Dec 3, 2020

[test-install](https://ci.brave.com/job/pr-brave-browser-bt_iOS-Sync-Compile-windows/3/execution/node/272/log/) had a problem on Windows and on iOS gn-check` had an warning (not introduced by this PR). All other platforms ran great

Ready for merge! 😄

@bsclifton bsclifton merged commit 16a6576 into master Dec 3, 2020
@bsclifton bsclifton deleted the bt_iOS-Sync-Compile branch December 3, 2020 06:30
@bsclifton bsclifton added this to the 1.20.x - Nightly milestone Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix iOS compiling
3 participants