Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Greaselion extensions in user data dir and delete on exit #7141

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Nov 13, 2020

Resolves brave/brave-browser#12264
Resolves brave/brave-browser#12350

Previously we were unpacking the Greaselion extensions into a temporary directory not under our control. Those extensions were sometimes being deleted mid-session, which led to our translations not being found. In addition, the extensions weren't being deleted on service exit. This PR addresses both of those issues.

Submitter Checklist:

Test Plan:

I recommend trying this many times in various tabs. We should also test closing the tab and then restoring it with Ctrl+Shift+T. Can also test with various Rewards media publishers.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@LaurenWags
Copy link
Member

Verified using

Brave	1.19.13 Chromium: 87.0.4280.60 (Official Build) nightly (x86_64)
Revision	12697cfeb273d7de95cf9b18350d2c457f58224c-refs/branch-heads/4280@{#1352}
OS	macOS Version 10.14.6 (Build 18G6042)

Verified test plan from #7141 (comment)

Opened multiple tabs w/ in-line tip buttons. Examples:

Navigated thru the various pages to confirm "Tip" text and button were displayed.
Opened new pages via context menu and confirmed when page loaded the "Tip" text and button were displayed.
Closed tabs and reopened using cmd+shift+T and confirmed when page loaded the "Tip" text and button were displayed.
Left various pages as active and then closed/reopened the browser. On relaunch pages generally showed the "Tip" text and button, except for Twitter pages. This is logged with brave/brave-browser#11825. Confirmed reloading a tab that was left over from previous session showed the "Tip" text and button once page loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants