Store Greaselion extensions in user data dir and delete on exit #7141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#12264
Resolves brave/brave-browser#12350
Previously we were unpacking the Greaselion extensions into a temporary directory not under our control. Those extensions were sometimes being deleted mid-session, which led to our translations not being found. In addition, the extensions weren't being deleted on service exit. This PR addresses both of those issues.
Submitter Checklist:
npm run lint
,npm run gn_check
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).QA/Yes
orQA/No
) to the associated issuerelease-notes/include
orrelease-notes/exclude
) to the associated issueTest Plan:
I recommend trying this many times in various tabs. We should also test closing the tab and then restoring it with Ctrl+Shift+T. Can also test with various Rewards media publishers.
Reviewer Checklist:
After-merge Checklist:
changes has landed on.