Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12351: Fix flaky adblocker test. #7115

Merged
merged 1 commit into from
Nov 11, 2020
Merged

12351: Fix flaky adblocker test. #7115

merged 1 commit into from
Nov 11, 2020

Conversation

iefremov
Copy link
Contributor

@iefremov iefremov commented Nov 11, 2020

brave/brave-browser#12351

Resolves

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@iefremov iefremov self-assigned this Nov 11, 2020
@iefremov iefremov added the tests label Nov 11, 2020
Copy link
Collaborator

@antonok-edm antonok-edm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I was so close to updating this too in #7030 - if only I'd noticed there was a usage of ExecuteScript rather than just ExecuteScriptAndExtractBool... good catch 😅

@iefremov iefremov merged commit 511b3d9 into master Nov 11, 2020
@iefremov iefremov deleted the ie_fix_flaky_subframe branch November 11, 2020 12:17
@iefremov iefremov added this to the 1.18.x - Nightly milestone Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants