Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave Ads crash when shutting down ads service if ads service is starting - 1.16.x #6936

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Brave Ads crash when shutting down ads service if ads service is starting - 1.16.x #6936

merged 1 commit into from
Oct 23, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Oct 23, 2020 •
edited by kjozwiak
Loading

Uplift of #6915
Resolves brave/brave-browser#12037

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey requested a review from a team October 23, 2020 09:46
@tmancey tmancey self-assigned this Oct 23, 2020
@tmancey tmancey added this to the 1.16.x - Release milestone Oct 23, 2020
@tmancey tmancey force-pushed the issues/12037-1.16.x branch from 8ce257b to aaf423a Compare October 23, 2020 09:56
@kjozwiak kjozwiak mentioned this pull request Oct 23, 2020
Merged
4 tasks
@kjozwiak
Copy link
Member

Restarting Win x64 via https://ci.brave.com/job/pr-brave-browser-issues-12037-1.16.x-windows/4/ as test-install failed as per https://ci.brave.com/job/pr-brave-browser-issues-12037-1.16.x-windows/3/execution/node/261/log/. It also failed on #6937 so going to restart just in case.

@kjozwiak
Copy link
Member

test-install failed on Win x64 again. Searched through our CI channel on Slack and found that the above is a known intermittent issue that's not related to this PR.

kjozwiak
kjozwiak approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.17.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #6915 (comment).

@kjozwiak kjozwiak merged commit 9be210d into 1.16.x Oct 23, 2020
@kjozwiak kjozwiak deleted the issues/12037-1.16.x branch October 23, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@tmancey tmancey

Labels
bug feature/ads
Projects
None yet
Milestone
1.16.x - Release #1
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @kjozwiak