Validate HTML tags in UI strings. #6720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkarolin
force-pushed
the
maxk-check-html-tags-in-strings
branch
4 times, most recently
from
9e60b3f to
6c4ec08
Compare
mkarolin
force-pushed
the
maxk-check-html-tags-in-strings
branch
2 times, most recently
from
446037d to
00f8ab8
Compare
Changed the rebase script to automatically fix <a> links with target="_blank" to also have rel="noopener noreferrer". Modified transifex script to: * Fix <a> links when pulling translations from local Chromium .xtb files. * Validate embedded HTML tags in strings against an allow list when uploading .grd(p) files to transifex. * Do the same when downloading strings from Transifex. * Completely strip all content from <ph> tags in .xtb files like Chromium does when pulling from Transifex.
bbondy
reviewed
Oct 2, 2020
| @@ -782,7 +938,7 @@ def pull_xtb_without_transifex(grd_file_path, brave_source_root): | |||
| # A node's fingerprint changes if the desc or the meaning change | |||
| if (pre_text_node != textify(node) or | |||
| pre_meaning != meaning or | |||
| pre_desc == desc): | |||
| pre_desc != desc): | |||
bbondy
approved these changes
Oct 2, 2020
|
thanks @mkarolin ! |
mkarolin
added a commit
that referenced
this pull request
Oct 8, 2020
Validate HTML tags in UI strings.
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#11767
Submitter Checklist:
npm run lint,npm run gn_check)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.