Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11486 - DCHECK failure in RphFromRequest #6522

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Aug 27, 2020

Resolves brave/brave-browser#11486

Submitter Checklist:

Test Plan:

CI should pass

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@jumde jumde merged commit 52ae737 into master Aug 28, 2020
@jumde jumde deleted the rphfromrequest_dcheck branch August 28, 2020 16:37
@jumde jumde added this to the 1.15.x - Nightly milestone Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DCHECK failure in RphFromRequest
3 participants