-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persists widget menus when they aren't in the foreground #6327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…n't in the foreground
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't had a chance to test but code looks pretty good!
CI failures unrelated |
Persists widget menus when they aren't in the foreground
Persists widget menus when they aren't in the foreground
Verified brave/brave-browser#10749 using
|
|
Fixes brave/brave-browser#10199, brave/brave-browser#10749
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Defined in issue
Reviewer Checklist:
After-merge Checklist:
changes has landed on.