Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 32-bit Windows build with 10.0.19041 SDK (1.13.x). #6254

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#10977
Uplift from #6237

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Fixes 32-bit Windows build with 10.0.19041 SDK.
@mkarolin mkarolin added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jul 29, 2020
@mkarolin mkarolin added this to the 1.13.x - Beta milestone Jul 29, 2020
@mkarolin mkarolin requested a review from a team July 29, 2020 20:18
@mkarolin mkarolin requested a review from bridiver as a code owner July 29, 2020 20:18
@mkarolin mkarolin self-assigned this Jul 29, 2020
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 541269b into 1.13.x Jul 30, 2020
@bsclifton bsclifton deleted the maxk-fix-x86-10.0.19041-winsdk-1.13.x branch July 30, 2020 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants