Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fingerprints calculation for elements with Chrome->Brave changes in the meaning attribute #6174

Merged
merged 2 commits into from
Jul 22, 2020

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jul 22, 2020

This also includes a pull from Transifex and some "incognito-> private" and related fixes

Resolves brave/brave-browser#10746
Resolves brave/brave-browser#10745
Resolves brave/brave-browser#10755

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bbondy bbondy added this to the 1.13.x - Nightly milestone Jul 22, 2020
@bbondy bbondy requested a review from mkarolin July 22, 2020 19:12
@bbondy bbondy self-assigned this Jul 22, 2020
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@kjozwiak
Copy link
Member

kjozwiak commented Jul 23, 2020

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.13.40 Chromium: 84.0.4147.89 (Official Build) nightly (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | macOS Version 10.15.6 (Build 19G73)
Polish Japanese French
Zrzut ekranu 2020-07-23 o 9 47 15 AM スクリーンショット 2020-07-23 午前9 48 11 Capture d’écran, le 2020-07-23 à 09 49 12
Polish Japanese French
Screen Shot 2020-07-23 at 10 55 01 AM Screen Shot 2020-07-23 at 11 01 51 AM Screen Shot 2020-07-23 at 11 04 08 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants