Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement navigator.hardwareConcurrency farbling #6156

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Jul 21, 2020

Resolves brave/brave-browser#10808

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@pilgrim-brave pilgrim-brave requested a review from bridiver as a code owner July 21, 2020 22:28
@pilgrim-brave pilgrim-brave marked this pull request as draft July 21, 2020 22:28
@pilgrim-brave pilgrim-brave self-assigned this Jul 21, 2020
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_navigator_hardwareconcurrency branch 3 times, most recently from 1ca4cef to 425cee9 Compare August 12, 2020 17:51
@pilgrim-brave pilgrim-brave marked this pull request as ready for review August 12, 2020 17:51
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_navigator_hardwareconcurrency branch from 425cee9 to fd2a23b Compare August 12, 2020 19:47
Copy link
Collaborator

@bridiver bridiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_navigator_hardwareconcurrency branch 2 times, most recently from e58bae9 to 8fff48f Compare August 13, 2020 14:56
lint

.

tests

patch IDL instead

.

lint

.

.
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_navigator_hardwareconcurrency branch from 8fff48f to 9f6deda Compare August 13, 2020 16:31
@pilgrim-brave pilgrim-brave merged commit bea220b into master Aug 13, 2020
@pilgrim-brave pilgrim-brave deleted the mpilgrim_navigator_hardwareconcurrency branch August 13, 2020 18:52
@pilgrim-brave pilgrim-brave added this to the 1.14.x - Nightly milestone Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fingerprinting 2.0: hardwareConcurrency
2 participants