Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Fix for shields on custom tabs (uplift to 1.11.x) #6044

Merged
merged 1 commit into from
Jul 9, 2020
Merged

[Android] Fix for shields on custom tabs (uplift to 1.11.x) #6044

merged 1 commit into from
Jul 9, 2020

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Jul 8, 2020 •
edited by kjozwiak
Loading

Uplift of #6040
Resolves brave/brave-browser#10612

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@samartnik samartnik added this to the 1.11.x - Release milestone Jul 8, 2020
@samartnik samartnik requested a review from a team July 8, 2020 22:08
@samartnik samartnik changed the title [Android] Fix for shields on custom tabs [Android] Fix for shields on custom tabs (uplift to 1.11.x) Jul 8, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Jul 9, 2020

Only failures are audit-deps due to lodash which is a known issue and has been fixed on 1.13.x and 1.12.x.

kjozwiak
kjozwiak approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.11.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #6040 (comment).

@kjozwiak kjozwiak merged commit eaef312 into 1.11.x Jul 9, 2020
@kjozwiak kjozwiak deleted the pr6040_android_custom_tab_shields_fix_1.11.x branch July 9, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.11.x - Release #1
Development

Successfully merging this pull request may close these issues.
3 participants
@samartnik @kjozwiak @brave-builds