Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DEPS after https://github.com/brave/brave-extension/pull/69 #589

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Update DEPS after https://github.com/brave/brave-extension/pull/69 #589

merged 1 commit into from
Oct 9, 2018

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Oct 9, 2018

Fixes brave/brave-browser#729

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@pilgrim-brave pilgrim-brave requested a review from bbondy October 9, 2018 13:22
@bbondy bbondy merged commit 3a69459 into brave:master Oct 9, 2018
bbondy added a commit that referenced this pull request Oct 9, 2018
bbondy added a commit that referenced this pull request Oct 9, 2018
@bbondy
Copy link
Member

bbondy commented Oct 9, 2018

master: 3a69459
0.56.x: dd4149c
0.55.x: 7e8ae21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block All Cookies in shields doesn't truly block all cookies
2 participants