-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes balance being an empty string #5883
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriusA
force-pushed
the
rewards-bat-support/11
branch
from
June 17, 2020 19:34
2b0ec6f
to
7df7402
Compare
AndriusA
force-pushed
the
rewards-bat-support/11
branch
from
June 17, 2020 21:42
7df7402
to
9378817
Compare
emerick
approved these changes
Jun 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a couple of minor comments
NejcZdovc
reviewed
Jun 18, 2020
AndriusA
force-pushed
the
rewards-bat-support/11
branch
from
June 18, 2020 07:13
9378817
to
4c442af
Compare
NejcZdovc
approved these changes
Jun 18, 2020
AndriusA
force-pushed
the
rewards-bat-support/11
branch
from
June 18, 2020 11:11
4c442af
to
1c60e1e
Compare
4 tasks
Verification PASSED on
Example:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#10315
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Steps to reproduce issue (Verified on Brave Dev 1.11.82 on Macos):
POST
requests tov2/wallet/WALLET_ID/claim
endpoint including"denomination":{"amount":"","currency":"BAT"}
in the body and server responses with error code 500For testing, browser was launched with:
And relevant output:
With the issue fixed and calls to
v2/wallet/WALLET_ID/claim
should not be made oramount
in the POST payload should be a non-empty numeric stringReviewer Checklist:
After-merge Checklist:
changes has landed on.