Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement farbling levels for webaudio #5794

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Jun 9, 2020

Resolves brave/brave-browser#9187

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@pilgrim-brave pilgrim-brave self-assigned this Jun 9, 2020
@pilgrim-brave
Copy link
Contributor Author

All relevant tests passed. CI test failure is 1 unrelated test timing out.

@@ -20,6 +20,36 @@
#include "third_party/blink/renderer/platform/heap/handle.h"
#include "third_party/blink/renderer/platform/supplementable.h"

#define LFSR_NEXT \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why a define instead of a method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could probably do an inline method. I just wanted to ensure it was inline and this was the first thing I thought of.

code and tests

use inline function instead of define
@pilgrim-brave pilgrim-brave merged commit bbd867e into master Jun 11, 2020
@pilgrim-brave pilgrim-brave deleted the mpilgrim_webaudio_v2 branch June 11, 2020 12:59
brave-builds pushed a commit that referenced this pull request Jun 11, 2020
@bsclifton bsclifton added this to the 1.12.x - Nightly milestone Jun 18, 2020
bsclifton pushed a commit that referenced this pull request Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fingerprinting 2.0: Web Audio
3 participants