-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement farbling levels for webaudio #5794
Conversation
All relevant tests passed. CI test failure is 1 unrelated test timing out. |
@@ -20,6 +20,36 @@ | |||
#include "third_party/blink/renderer/platform/heap/handle.h" | |||
#include "third_party/blink/renderer/platform/supplementable.h" | |||
|
|||
#define LFSR_NEXT \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why a define instead of a method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could probably do an inline method. I just wanted to ensure it was inline and this was the first thing I thought of.
code and tests use inline function instead of define
92a3738
to
20ed9ac
Compare
Resolves brave/brave-browser#9187
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.