Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes extensions install prompt (1.11.x). #5788

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Jun 9, 2020

Fixes brave/brave-browser#10113
Uplift from #5772

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 1.11.x - Beta milestone Jun 9, 2020
@mkarolin mkarolin requested a review from a team June 9, 2020 18:58
@mkarolin mkarolin requested a review from bridiver as a code owner June 9, 2020 18:58
@mkarolin mkarolin self-assigned this Jun 9, 2020
@LaurenWags
Copy link
Member

@mkarolin mkarolin added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Jun 10, 2020
@kjozwiak
Copy link
Member

Looks like test-install failed as per https://ci.brave.com/job/pr-brave-browser-maxk-fix-extensions-prompt-1.11.x/2/execution/node/376/log/. However, this is a known issue that was supposed to be fixed/resolved. However, looks like it's still happening. Updated brave/brave-browser#9480.

However, this doesn't block uplift.

Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.11.x approved after deliberating with @brave/uplift-approvers. As per #5788 (comment), the failures on CI are known issues and not blocking uplift.

@LaurenWags LaurenWags merged commit 958e4ed into 1.11.x Jun 10, 2020
@LaurenWags LaurenWags deleted the maxk-fix-extensions-prompt-1.11.x branch June 10, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants