Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes password bubble. #5743

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Fixes password bubble. #5743

merged 1 commit into from
Jun 4, 2020

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Jun 4, 2020

Replaces 1x1 empty images that we use to overwrite chromium images with
images of 1 x original image width, so that they don't get scaled to the
preferred width of the bubble as squares.

Fixes brave/brave-browser#10008

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Replaces 1x1 empty images that we use to overwrite chromium images with
images of 1 x original image width, so that they don't get scaled to the
preferred width of the bubble.

Fixes brave/brave-browser#10008
@mkarolin mkarolin added this to the 1.12.x - Nightly milestone Jun 4, 2020
@mkarolin mkarolin self-assigned this Jun 4, 2020
@bsclifton
Copy link
Member

Tested on Windows; 100% DPI, both in light and dark mode. I have been able to reproduce the issue locally without any problems:

image
image

@mkarolin mkarolin requested a review from bsclifton June 4, 2020 20:53
@mkarolin mkarolin added the CI/skip Do not run CI builds (except noplatform) label Jun 4, 2020
@mkarolin mkarolin marked this pull request as ready for review June 4, 2020 20:54
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! I also backed out the change and verified it's broken before this. Nice work! 😄

@bsclifton
Copy link
Member

Without the fix:
image

@mkarolin mkarolin merged commit ea42ff0 into master Jun 4, 2020
@mkarolin mkarolin deleted the maxk-issue-10008-2 branch June 4, 2020 20:57
mkarolin added a commit that referenced this pull request Jun 4, 2020
@mkarolin mkarolin mentioned this pull request Jun 4, 2020
32 tasks
mkarolin added a commit that referenced this pull request Jun 4, 2020
petemill added a commit that referenced this pull request Jul 27, 2020
Overwrite chromium theme/x/common directory for avatar placeholder
petemill added a commit that referenced this pull request Jul 28, 2020
Overwrite chromium theme/x/common directory for avatar placeholder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

save password prompt has graphic (C83)
2 participants