-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes password bubble. #5743
Merged
Merged
Fixes password bubble. #5743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces 1x1 empty images that we use to overwrite chromium images with images of 1 x original image width, so that they don't get scaled to the preferred width of the bubble. Fixes brave/brave-browser#10008
bsclifton
approved these changes
Jun 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! I also backed out the change and verified it's broken before this. Nice work! 😄
32 tasks
petemill
added a commit
that referenced
this pull request
Jul 27, 2020
Overwrite chromium theme/x/common directory for avatar placeholder
petemill
added a commit
that referenced
this pull request
Jul 28, 2020
Overwrite chromium theme/x/common directory for avatar placeholder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces 1x1 empty images that we use to overwrite chromium images with
images of 1 x original image width, so that they don't get scaled to the
preferred width of the bubble as squares.
Fixes brave/brave-browser#10008
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.