Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP: do not hide bandwidth savings when 0 #5711

Merged
merged 1 commit into from
Jun 10, 2020
Merged

NTP: do not hide bandwidth savings when 0 #5711

merged 1 commit into from
Jun 10, 2020

Conversation

AndriusA
Copy link

@AndriusA AndriusA commented Jun 2, 2020

Resolves brave/brave-browser#9993

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@AndriusA AndriusA self-assigned this Jun 2, 2020
@AndriusA AndriusA requested a review from petemill June 2, 2020 10:05
@AndriusA
Copy link
Author

AndriusA commented Jun 2, 2020

Only unrelated test (BraveRewardsBrowserTest.CheckIfReconcileWasResetEmpty) fails on CI

@rebron rebron requested a review from bsclifton June 2, 2020 16:58
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 😄 👍

@bsclifton bsclifton merged commit 5b58dd7 into master Jun 10, 2020
@bsclifton bsclifton deleted the ntp-bandwidth branch June 10, 2020 08:27
@bsclifton bsclifton added this to the 1.12.x - Nightly milestone Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] NTP Estimated bandwidth saved stat is not shown on clean install
2 participants