Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset reconcile stamp even if ac is off #5692

Merged
merged 1 commit into from
May 29, 2020
Merged

Reset reconcile stamp even if ac is off #5692

merged 1 commit into from
May 29, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented May 29, 2020

Resolves brave/brave-browser#10006

Submitter Checklist:

Test Plan:

  • defined in the issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.11.x - Nightly milestone May 29, 2020
@NejcZdovc NejcZdovc requested a review from a team May 29, 2020 16:54
@NejcZdovc NejcZdovc self-assigned this May 29, 2020
@NejcZdovc NejcZdovc requested a review from emerick May 29, 2020 17:00
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a comment about a log typo.

return;
}

BLOG(1, "Staring monthly contribution");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Not really changed here, but maybe we can fix the typo: Staring -> Starting

@NejcZdovc NejcZdovc merged commit a89eca5 into master May 29, 2020
@NejcZdovc NejcZdovc deleted the reconcile-reset branch May 29, 2020 21:07
@kjozwiak
Copy link
Member

kjozwiak commented Jun 1, 2020

Reproduced the original issue using the STR outlined under brave/brave-browser#10006 using the following build:

Brave | 1.10.79 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
--- | ---
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.15.4 (Build 19E287)

Verification PASSED on macOS 10.15.4 x64 Catalina using the following build:

Brave | 1.11.41 Chromium: 83.0.4103.61 (Official Build) nightly (64-bit)
--- | ---
Revision | 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS | macOS Version 10.15.4 (Build 19E287)

Test Case #1 (original issue)

Test Case #2 (a-c with monthly recurring tips)

Screen Shot 2020-06-01 at 6 24 21 PM

Screen Shot 2020-06-01 at 6 24 25 PM

  • restarted the browser and ensured that both a-c and monthly recurring tips didn't go through right after relaunch
  • waited another ~5min as per --rewards=staging=true,reconcile-interval=5 and ensured that both a-c and monthly recurring tips went through without issues

Screen Shot 2020-06-01 at 6 28 30 PM

Screen Shot 2020-06-01 at 6 28 35 PM

Test Case #3 (a-c without monthly recurring tips)

Screen Shot 2020-06-01 at 6 44 39 PM

Screen Shot 2020-06-01 at 6 44 28 PM

  • restarted the browser and ensured that a-c didn't go through right after relaunch
  • waited another ~5min as per --rewards=staging=true,reconcile-interval=5 and ensured that a-c went through without issues

Screen Shot 2020-06-01 at 6 51 53 PM

Screen Shot 2020-06-01 at 6 51 53 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

monthly contributions contributing again after browser restart when AC is disabled
4 participants