Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Saved Passwords section in settings is empty #5656

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Fixed Saved Passwords section in settings is empty #5656

merged 1 commit into from
Jun 3, 2020

Commits on Jun 2, 2020

  1. Fixed Saved Passwords section in settings is empty 

    Some users reported that Saved Passwords sections is empty but passwords are autofilled
to website's password form on linux and macOS.

I think this can happen if user insert/update new password entries after login db encryption
is corrupted.
However, currently user can't anything even if current login db has decryptable entries.

The reason is LoginDatabase::StatementToForms() gives empty password entry when any entry in
login db has decryption failure on linux and macOS.

To fix this, ENCRYPTION_RESULT_ITEM_FAILURE is use for individual decryption failure
instead of ENCRYPTION_RESULT_SERVICE_FAILURE.

If ENCRYPTION_RESULT_SERVICE_FAILURE is returned, LoginDatabase::StatementToForms() assumes
all other entries will have decrypt failure. However, db could have decryptable entries
even if current entry is failed to decrypt.
    @simonhong
    simonhong committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    ba2de6f View commit details
    Browse the repository at this point in the history