Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade patches from Chromium 81.0.4044.129 to Chromium 81.0.4044.138 (1.8.x). #5468

Merged
merged 1 commit into from
May 7, 2020

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented May 6, 2020

Fixes brave/brave-browser#9632
Related PR: brave/brave-browser#9649

Uplift from #5463

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Upgrade patches from Chromium 81.0.4044.129 to Chromium 81.0.4044.138
@mkarolin mkarolin added the CI/run-network-audit Run network-audit label May 6, 2020
@mkarolin mkarolin added this to the 1.8.x - Release Hotfix 2 milestone May 6, 2020
@mkarolin mkarolin requested a review from a team May 6, 2020 05:18
@mkarolin mkarolin requested a review from bridiver as a code owner May 6, 2020 05:18
@mkarolin mkarolin self-assigned this May 6, 2020
@bsclifton bsclifton added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels May 6, 2020
@bsclifton
Copy link
Member

CI ran was successful, with one intermittent rewards related browser test failure on macOS:

12:15:23  [  FAILED  ] BraveRewardsBrowserTest.NotVerifiedWallet, where TypeParam =  and GetParam() =  (6143 ms)
12:15:23  [542/542] BraveRewardsBrowserTest.NotVerifiedWallet (6347 ms)
12:15:23  1 test failed:
12:15:23      BraveRewardsBrowserTest.NotVerifiedWallet (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2323)

This is a known issue; captured with brave/brave-browser#9339

PR is good to go- ready for consideration 😄

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.8.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 4278165 into 1.8.x May 7, 2020
@kjozwiak kjozwiak deleted the 81.0.4044.138-1.8.x branch May 7, 2020 03:13
bsclifton pushed a commit that referenced this pull request May 7, 2020
Upgrade patches from Chromium 81.0.4044.129 to Chromium 81.0.4044.138 (1.8.x).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants