Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: setting bg brave ads off. Issue #8641. #5348

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Conversation

gdregalo
Copy link
Contributor

Resolves brave/brave-browser#8641

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@gdregalo gdregalo added feature/rewards CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Apr 23, 2020
@gdregalo gdregalo added this to the 1.10.x - Nightly milestone Apr 23, 2020
@gdregalo gdregalo self-assigned this Apr 23, 2020
@gdregalo
Copy link
Contributor Author

@brave/legacy_qa
Please test next scenarios.

Scenario 1.

  1. Have the previous version of Brave installed.
  2. Set Brave Bg adds to ON.
  3. Update the app with the version having this PR.
    Expected result: Brave Bg adds are set to OFF.
  4. Restart the app and make sure the value has not changed.

Scenario 2.

  1. Have the previous version of Brave installed.
  2. Set Brave Bg adds to OFF.
  3. Update the app with the version having this PR.
    Expected result: Brave Bg adds are set to OFF.
  4. Restart the app and make sure the value has not changed.

Scenario 3.

  1. Do clean install of the app with the version having this PR.
    Expected result: Brave Bg adds are set to OFF.
  2. Restart the app and make sure the value has not changed.

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gdregalo gdregalo merged commit f8305a2 into master Apr 24, 2020
@gdregalo gdregalo deleted the bg-ads-off branch April 24, 2020 02:08
@srirambv
Copy link
Contributor

srirambv commented May 4, 2020

Verification passed on OnePlus 6T with Android 10

  • Verified with setting enabled on 1.9.21 nightly build upgrading to 1.10.22 disables setting
  • Verified with setting disabled on 1.9.21 nightly build upgrading to 1.10.22 retains the settings
  • Verified setting is retained between browser launches
  • Verified on clean install setting is disabled by default and is retained between relaunches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable background ads on Android
4 participants