Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding MIT license for crypto-icons assets (Uplift to 1.9) #5344

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Adding MIT license for crypto-icons assets (Uplift to 1.9) #5344

merged 1 commit into from
Apr 24, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Apr 23, 2020 •
edited by kjozwiak
Loading

Uplift of: #5332

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@ryanml ryanml added the CI/skip Do not run CI builds (except noplatform) label Apr 23, 2020
@ryanml ryanml added this to the 1.9.x - Beta milestone Apr 23, 2020
@ryanml ryanml requested a review from a team April 23, 2020 18:03
@ryanml ryanml self-assigned this Apr 23, 2020
@ryanml ryanml removed the CI/skip Do not run CI builds (except noplatform) label Apr 23, 2020
@ryanml @bsclifton
Merge pull request #5332 from brave/fix-9407
1ce3b15 
Adding MIT license for crypto-icons font
@kjozwiak
Copy link
Member

QA verified #5332 on Nightly as per #5332 (comment).

kjozwiak
kjozwiak approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.9.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 45b1431 into 1.9.x Apr 24, 2020
@kjozwiak kjozwiak deleted the fix-9407-1.9 branch April 24, 2020 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@ryanml ryanml

Labels
None yet
Projects
None yet
Milestone
1.9.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanml @kjozwiak