Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for empty content setting rules #5341

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Apr 23, 2020

fix brave/brave-browser#9421

Resolves

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bridiver bridiver requested a review from pilgrim-brave April 23, 2020 16:16
@bridiver bridiver self-assigned this Apr 23, 2020
@bridiver
Copy link
Collaborator Author

merging because this fixes a crash, but I can't get anything to pass in CI right now for any PR

@bridiver bridiver merged commit 44e12d7 into master Apr 23, 2020
@bridiver bridiver deleted the farbling-content-setting-fix branch April 23, 2020 20:26
@bbondy bbondy added this to the 1.10.x - Beta milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser test failing DCHECK in brave_content_settings_agent_impl.cc
3 participants