Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing widget menus going offscreen at certain viewports #5319

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Apr 22, 2020

Fixes: brave/brave-browser#9390
Fixes: brave/brave-browser#9078
Fixes: brave/brave-browser#9389

This was an issue between 950px and 1150px

Screen Shot 2020-04-22 at 12 56 23 PM

Screen Shot 2020-04-22 at 12 56 02 PM

Screen Shot 2020-04-22 at 12 55 55 PM

Screen Shot 2020-04-22 at 12 55 15 PM

Screen Shot 2020-04-22 at 12 55 08 PM

Screen Shot 2020-04-22 at 12 54 58 PM

Submitter Checklist:

Test Plan:

Defined in issues

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 1.10.x - Nightly milestone Apr 22, 2020
@ryanml ryanml requested review from bbondy and cezaraugusto April 22, 2020 20:01
@ryanml ryanml self-assigned this Apr 22, 2020
@ryanml
Copy link
Contributor Author

ryanml commented Apr 23, 2020

Simple css change - travis passes, Jenkins unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants