windows appears to sometimes move the unique_ptr and send an empty Pu… #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…blisherInfo to SavePublisherInfoOnFileTaskRunner. Explicitly make a copy before binding the callback fix brave/brave-browser#1326
bridiver
commented
Sep 29, 2018
| @@ -575,9 +575,10 @@ void RewardsServiceImpl::OnPublisherStateSaved( | |||
| void RewardsServiceImpl::SavePublisherInfo( | |||
| std::unique_ptr<ledger::PublisherInfo> publisher_info, | |||
| ledger::PublisherInfoCallback callback) { | |||
| ledger::PublisherInfo info_copy = *publisher_info; | |||
There was a problem hiding this comment.
not sure why this fixes it because it shouldn't actually change anything, but I can't repro after this change. Maybe a compiler bug?
|
As per slack you mentioned it works after this fix but not before and you could repro, so merging. But I don't understand why this should help. |
bbondy
approved these changes
Sep 29, 2018
bbondy
added a commit
that referenced
this pull request
Sep 29, 2018
windows appears to sometimes move the unique_ptr and send an empty Pu…
bbondy
added a commit
that referenced
this pull request
Sep 29, 2018
windows appears to sometimes move the unique_ptr and send an empty Pu…
|
I don't understand either, but it was verified by @ryanml so maybe a win clang bug? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…blisherInfo to SavePublisherInfoOnFileTaskRunner. Explicitly make a copy before binding the callback
fix brave/brave-browser#1326
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: