Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binance version 2 trading widget #5160

Merged
merged 60 commits into from
Apr 10, 2020
Merged

Binance version 2 trading widget #5160

merged 60 commits into from
Apr 10, 2020

Commits on Apr 9, 2020

  1. Initial NTP widget with buy support

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    dc115fc View commit details
    Browse the repository at this point in the history

  2. Adding front-end resources for full widget

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    4c354c2 View commit details
    Browse the repository at this point in the history

  3. Adding backend API, controller, service

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    9aa0fd3 View commit details
    Browse the repository at this point in the history

  4. Adding PKCE code challenge store

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    2ed0595 View commit details
    Browse the repository at this point in the history

  5. Adding account balance retrieval, json parser tests

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    953a7ea View commit details
    Browse the repository at this point in the history

  6. Adding conversion quote endpoint

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    887f80b View commit details
    Browse the repository at this point in the history

  7. Adding V1 API code, TickerPrice and Volume endpoints

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    4270169 View commit details
    Browse the repository at this point in the history

  8. Collapse BinanceController into BinanceService

    @bbondy @ryanml
    bbondy authored and ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    8ddd979 View commit details
    Browse the repository at this point in the history

  9. Return correct success boolean

    @bbondy @ryanml
    bbondy authored and ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    c51f636 View commit details
    Browse the repository at this point in the history

  10. Add BAT to currency lookup table and create a fallback

    @bbondy @ryanml
    bbondy authored and ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    33f80ef View commit details
    Browse the repository at this point in the history

  11. Fixup where Binance buildflags

    @bbondy @ryanml
    bbondy authored and ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    f3f84ff View commit details
    Browse the repository at this point in the history

  12. Fix oauth flow w/ binance: protocol handler 

    We're likely to remove the static network redirect as long as Binance
can update to the binance: protocol handler.
    @bbondy @ryanml
    bbondy authored and ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    47e852b View commit details
    Browse the repository at this point in the history

  13. Fix missing dep on some buildflags 

    Both Binance and Crypto Wallets wouldn't always rebuild properly if you changed this value
    @bbondy @ryanml
    bbondy authored and ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    3f3a22f View commit details
    Browse the repository at this point in the history

  14. Use build config for client and secret

    @bbondy @ryanml
    bbondy authored and ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    b1a019e View commit details
    Browse the repository at this point in the history

  15. Update callback url to com.brave.binance scheme

    @bbondy @ryanml
    bbondy authored and ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    de5556d View commit details
    Browse the repository at this point in the history

  16. Fixup PKCE flow and param encoding

    @bbondy @ryanml
    bbondy authored and ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    4e562ce View commit details
    Browse the repository at this point in the history

  17. Handle code challenge and verifier on C++ side

    @bbondy @ryanml
    bbondy authored and ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    a1d2476 View commit details
    Browse the repository at this point in the history

  18. Fixing namespace, pref registry

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    ab59677 View commit details
    Browse the repository at this point in the history

  19. Use GET method for user balance 

    And fix status to return correct success code.
    @bbondy @ryanml
    bbondy authored and ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    f2ee207 View commit details
    Browse the repository at this point in the history

  20. Remove binance_client_secret 

    It is no longer needed with the PKCE flow
    @bbondy @ryanml
    bbondy authored and ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    7b703f3 View commit details
    Browse the repository at this point in the history

  21. Front-end re-organization, lint fixes

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    7f46eea View commit details
    Browse the repository at this point in the history

  22. Removing Connect flow for US users

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    f262184 View commit details
    Browse the repository at this point in the history

  23. wiring in asset volume, values in USD, BTC

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    ceb4010 View commit details
    Browse the repository at this point in the history

  24. Networking for user deposit info (address, url), wiring

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    d5e1eae View commit details
    Browse the repository at this point in the history

  25. Finishing remaining backend for conversions 

    Quotes, Confirm, Supported Assets
    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    8842356 View commit details
    Browse the repository at this point in the history

  26. Fix invalid Binance oauth scope

    @bbondy @ryanml
    bbondy authored and ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    a2d993e View commit details
    Browse the repository at this point in the history

  27. Front end cleanup, price and ticker fixes

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    5c2efc2 View commit details
    Browse the repository at this point in the history

  28. Adding QR code view + address copy

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    48f882a View commit details
    Browse the repository at this point in the history

  29. Using just asset address for QR code, small formatting fixes

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    66fc997 View commit details
    Browse the repository at this point in the history

  30. Adding convert asset lookup table, grabbing convert quote + timeout

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    1d75e30 View commit details
    Browse the repository at this point in the history

  31. Adding wiring for final conversion step

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    1de0ab9 View commit details
    Browse the repository at this point in the history

  32. Index render refactor

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    0e66d3a View commit details
    Browse the repository at this point in the history

  33. Localization, bug fixes

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    a48c3b3 View commit details
    Browse the repository at this point in the history

  34. Removing unused function

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    dedd323 View commit details
    Browse the repository at this point in the history

  35. Fixing invalid quote parameter, retyping

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    3ca88ff View commit details
    Browse the repository at this point in the history

  36. Setting convert expiry time to 30 seconds 

    Extra checks for unavailable addresses
    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    f7b194f View commit details
    Browse the repository at this point in the history

  37. Using full asset list for convert from

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    0ddbf2f View commit details
    Browse the repository at this point in the history

  38. Modifying baseAsset value, including extra currencies in list

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    5adf8db View commit details
    Browse the repository at this point in the history

  39. Adding invalid token/reconnect flow

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    922d33a View commit details
    Browse the repository at this point in the history

  40. Not using URL query for convert confirm request

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    1cc4fe3 View commit details
    Browse the repository at this point in the history

  41. Last minute display tweaks

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    82da535 View commit details
    Browse the repository at this point in the history

  42. Improved error handling for crypto conversions

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    74f5ed7 View commit details
    Browse the repository at this point in the history

  43. Updating binance_enabled build flag 

    Persisting connect button, BTC price fix
    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    c2869b0 View commit details
    Browse the repository at this point in the history

  44. Addressing code review comments

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    f6844ad View commit details
    Browse the repository at this point in the history

  45. Displaying total account balance in BTC, total USD value 

    Fixing issue with deposit single view overflow
    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    04949e8 View commit details
    Browse the repository at this point in the history

  46. Hiding dropdowns when clicking outside of them

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    a6e9551 View commit details
    Browse the repository at this point in the history

  47. Adding guard for migration, don't rely on accountBalances in buyView

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    5c0fb48 View commit details
    Browse the repository at this point in the history

  48. Fixing test build, NaN BTC value, migration path

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    e84402b View commit details
    Browse the repository at this point in the history

  49. Listing accounts with balances at the top

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    f245bbe View commit details
    Browse the repository at this point in the history

  50. Hiding balance by default, re-fetching clientURL on disconnect

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    68622b7 View commit details
    Browse the repository at this point in the history

  51. Fixes brave/brave-browser#9079 - Removes duplicate binance toggle entry

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    cef6edd View commit details
    Browse the repository at this point in the history

  52. Addressing review feedback

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    96316bc View commit details
    Browse the repository at this point in the history

  53. Moving connect button from header, disconnect action to widget menu

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    fa40f54 View commit details
    Browse the repository at this point in the history

  54. Implement review feedback

    @bbondy @ryanml
    bbondy authored and ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    596cb27 View commit details
    Browse the repository at this point in the history

  55. Make sure no API access in extensions

    @bbondy @ryanml
    bbondy authored and ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    3972d72 View commit details
    Browse the repository at this point in the history

  56. Add Binance service tests for all APIs

    @bbondy @ryanml
    bbondy authored and ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    06048c5 View commit details
    Browse the repository at this point in the history

  57. Moving data update actions to newTab, refresh action in menu

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    cb730fc View commit details
    Browse the repository at this point in the history

  58. Fixing bug where new NTP pages show un-authed view

    @ryanml
    ryanml committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    1d7fea7 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2020

  1. Reordering nav menu, fixing widget menu persistence

    @ryanml
    ryanml committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    8f64a15 View commit details
    Browse the repository at this point in the history

  2. Add and use API to revoke token

    @bbondy
    bbondy committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    74c48b1 View commit details
    Browse the repository at this point in the history