Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate definition added by https://github.com/brave/brave-core/pull/509 #511

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Remove duplicate definition added by https://github.com/brave/brave-core/pull/509 #511

merged 1 commit into from
Sep 26, 2018

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Sep 26, 2018 •
edited by bsclifton
Loading

fix brave/brave-browser#1309

Auditor: @yrliou, @bbondy, @mbacchi

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@darkdh darkdh requested review from bbondy, yrliou and mbacchi September 26, 2018 23:26
yrliou
yrliou approved these changes Sep 26, 2018
View reviewed changes
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, confirmed it fix build errors on mac

@darkdh darkdh merged commit 7c61da4 into master Sep 26, 2018
darkdh added a commit that referenced this pull request Sep 26, 2018
@darkdh
Merge pull request #511 from brave/widevine_cdm_component_installer
f3f65bc 
Remove duplicate definition added by #509
darkdh added a commit that referenced this pull request Sep 26, 2018
@darkdh
Merge pull request #511 from brave/widevine_cdm_component_installer
374d83c 
Remove duplicate definition added by #509
@darkdh
Copy link
Member Author

darkdh commented Sep 26, 2018

master: 7c61da4
0.55.x: f3f65bc
0.56.x: 374d83c

@bsclifton bsclifton deleted the widevine_cdm_component_installer branch September 26, 2018 23:36
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrliou yrliou yrliou approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@mbacchi mbacchi Awaiting requested review from mbacchi

Assignees

@darkdh darkdh

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release
Development

Successfully merging this pull request may close these issues.

build error: redefinition of 'RegisterWidevineCdmComponent'
3 participants
@darkdh @yrliou @bbondy