Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removes unneeded permiossions on Android #5096

Merged
merged 1 commit into from
Mar 30, 2020
Merged

removes unneeded permiossions on Android #5096

merged 1 commit into from
Mar 30, 2020

Conversation

SergeyZhukovsky
Copy link
Member

Resolves brave/brave-browser#8898

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@SergeyZhukovsky SergeyZhukovsky added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Mar 30, 2020
@SergeyZhukovsky SergeyZhukovsky added this to the 1.8.x - Nightly milestone Mar 30, 2020
@SergeyZhukovsky SergeyZhukovsky self-assigned this Mar 30, 2020
bridiver
bridiver approved these changes Mar 30, 2020
View reviewed changes
Copy link
Collaborator

@bridiver bridiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do a follow-up to see why you're having trouble with the other methods and also to handle the instance vars and constructor

@SergeyZhukovsky SergeyZhukovsky merged commit dae2071 into master Mar 30, 2020
@SergeyZhukovsky SergeyZhukovsky deleted the disable_android_permissions branch March 30, 2020 17:56
This was referenced Mar 30, 2020
Merged
Merged
AlexeyBarabash added a commit that referenced this pull request May 13, 2020
@AlexeyBarabash
Temporary revert brave-core PR #5096
7e163e0
AlexeyBarabash added a commit that referenced this pull request May 13, 2020
@AlexeyBarabash
WIP - some sync v2 operations work on Android:
1b5479d 
- lots of traces needs to be removed;
- can create sync chain;
- can display QR code or codewords allowing other devices to connect to the sync chain;
- can connect to existing sync chain by codewords or QR code;
- doesn't migrate (clean out) Android sync v1 data yet;
- doesn't allow to choose categories through UI yet;
- requires to redo the reverted brave-core PR #5096
AlexeyBarabash added a commit that referenced this pull request May 27, 2020
@AlexeyBarabash
Temporary revert brave-core PR #5096
1670f18
AlexeyBarabash added a commit that referenced this pull request May 27, 2020
@AlexeyBarabash
WIP - some sync v2 operations work on Android:
3f4d1c0 
- lots of traces needs to be removed;
- can create sync chain;
- can display QR code or codewords allowing other devices to connect to the sync chain;
- can connect to existing sync chain by codewords or QR code;
- doesn't migrate (clean out) Android sync v1 data yet;
- doesn't allow to choose categories through UI yet;
- requires to redo the reverted brave-core PR #5096
AlexeyBarabash added a commit that referenced this pull request Jun 3, 2020
@AlexeyBarabash
Temporary revert brave-core PR #5096
b6972d3
AlexeyBarabash added a commit that referenced this pull request Jun 3, 2020
@AlexeyBarabash
WIP - some sync v2 operations work on Android:
00676c2 
- lots of traces needs to be removed;
- can create sync chain;
- can display QR code or codewords allowing other devices to connect to the sync chain;
- can connect to existing sync chain by codewords or QR code;
- doesn't migrate (clean out) Android sync v1 data yet;
- doesn't allow to choose categories through UI yet;
- requires to redo the reverted brave-core PR #5096
AlexeyBarabash added a commit that referenced this pull request Jun 10, 2020
@AlexeyBarabash
Temporary revert brave-core PR #5096
04f2d73
AlexeyBarabash added a commit that referenced this pull request Jun 10, 2020
@AlexeyBarabash
WIP - some sync v2 operations work on Android:
ddbb19a 
- lots of traces needs to be removed;
- can create sync chain;
- can display QR code or codewords allowing other devices to connect to the sync chain;
- can connect to existing sync chain by codewords or QR code;
- doesn't migrate (clean out) Android sync v1 data yet;
- doesn't allow to choose categories through UI yet;
- requires to redo the reverted brave-core PR #5096
AlexeyBarabash added a commit that referenced this pull request Jun 14, 2020
@AlexeyBarabash
Temporary revert brave-core PR #5096
daae99d
AlexeyBarabash added a commit that referenced this pull request Jun 14, 2020
@AlexeyBarabash
WIP - some sync v2 operations work on Android:
ba74ea7 
- lots of traces needs to be removed;
- can create sync chain;
- can display QR code or codewords allowing other devices to connect to the sync chain;
- can connect to existing sync chain by codewords or QR code;
- doesn't migrate (clean out) Android sync v1 data yet;
- doesn't allow to choose categories through UI yet;
- requires to redo the reverted brave-core PR #5096
AlexeyBarabash added a commit that referenced this pull request Jun 22, 2020
@AlexeyBarabash
Temporary revert brave-core PR #5096
86df435
AlexeyBarabash added a commit that referenced this pull request Jun 22, 2020
@AlexeyBarabash
WIP - some sync v2 operations work on Android:
07b99c9 
- lots of traces needs to be removed;
- can create sync chain;
- can display QR code or codewords allowing other devices to connect to the sync chain;
- can connect to existing sync chain by codewords or QR code;
- doesn't migrate (clean out) Android sync v1 data yet;
- doesn't allow to choose categories through UI yet;
- requires to redo the reverted brave-core PR #5096
AlexeyBarabash added a commit that referenced this pull request Jun 22, 2020
@AlexeyBarabash
Reverted brave-core PR #5096
4c7d3a3
@AlexeyBarabash AlexeyBarabash mentioned this pull request Jun 22, 2020
Merged
32 tasks
AlexeyBarabash added a commit that referenced this pull request Jun 29, 2020
@AlexeyBarabash
Reverted brave-core PR #5096
6ef8013
@AlexeyBarabash AlexeyBarabash mentioned this pull request Aug 3, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridiver bridiver bridiver approved these changes

Assignees

@SergeyZhukovsky SergeyZhukovsky

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.8.x - Release
Development

Successfully merging this pull request may close these issues.

[Android] Disable unneeded permissions
2 participants
@SergeyZhukovsky @bridiver