Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only register cosmetic filter mutation observer if flag = enabled #4999

Merged
merged 1 commit into from
Mar 21, 2020

Conversation

pes10k
Copy link
Contributor

@pes10k pes10k commented Mar 21, 2020

Resolves :
brave/brave-browser#8749
brave/brave-browser#8779
brave/brave-browser#8741

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@pes10k pes10k force-pushed the fix-cpu-chew-from-disabled-cosmetic branch from ef48d6a to aa68c29 Compare March 21, 2020 01:26
@pes10k pes10k changed the title moved registration of mutation observer so that it only starts if cos… only register cosmetic filter mutation observer if flag = enabled Mar 21, 2020
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit e04aa54 into 1.5.x Mar 21, 2020
@bsclifton bsclifton deleted the fix-cpu-chew-from-disabled-cosmetic branch March 21, 2020 02:36
@bsclifton bsclifton added this to the 1.5.x - Release Hotfix 2 milestone Mar 21, 2020
bsclifton added a commit that referenced this pull request Mar 21, 2020
Follow up to #4999

Functionality (and tests) work as expected in 1.7 and later. Not enabled / needed for 1.5
bsclifton added a commit that referenced this pull request Mar 21, 2020
only register cosmetic filter mutation observer if flag = enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants