Shows brave://wallet alias under phishing detection and ENS redirect routes #4828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanml
commented
Mar 4, 2020
| @@ -38,6 +38,16 @@ void BraveLocationBarModelDelegate::FormattedStringFromURL(const GURL& url, | |||
| 0, | |||
| base::UTF8ToUTF16(ethereum_remote_client_base_url), | |||
| base::UTF8ToUTF16("brave://wallet")); | |||
| base::ReplaceFirstSubstringAfterOffset( | |||
There was a problem hiding this comment.
I think inside this conditional we're safe to just do a full string replace to brave://wallet, then this is future proofed for any other routes MM may add. @bbondy thoughts on safety?
There was a problem hiding this comment.
I think this is ok as you have it. I wonder if we could just have ethereum_remote_client_base_url not have /home.html but it's not a big deal since you already have it this way.
…ding/phishing routes
bbondy
approved these changes
Mar 4, 2020
| @@ -38,6 +38,16 @@ void BraveLocationBarModelDelegate::FormattedStringFromURL(const GURL& url, | |||
| 0, | |||
| base::UTF8ToUTF16(ethereum_remote_client_base_url), | |||
| base::UTF8ToUTF16("brave://wallet")); | |||
| base::ReplaceFirstSubstringAfterOffset( | |||
There was a problem hiding this comment.
I think this is ok as you have it. I wonder if we could just have ethereum_remote_client_base_url not have /home.html but it's not a big deal since you already have it this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: brave/brave-browser#8524
Resolves
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Defined in issue
Reviewer Checklist:
After-merge Checklist:
changes has landed on.