Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify link text in full disk access dialog #4780

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Feb 27, 2020

Resolves brave/brave-browser#8447

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong simonhong added this to the 1.7.x - Nightly milestone Feb 27, 2020
@simonhong simonhong self-assigned this Feb 27, 2020
Copy link
Collaborator

@rebron rebron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ Looks great. Sorry I didn't catch this earlier.

@simonhong
Copy link
Member Author

@rebron NP!
@bsclifton how about merging this immediately? I think it's fine because this is just text change.

@simonhong
Copy link
Member Author

Only CI on Windows was aborted but all others are fine.
Merged because this is just string change and this only targets on macOS. and CI for macOS is fine.

@simonhong simonhong merged commit aab4778 into master Feb 28, 2020
@simonhong simonhong deleted the full_disk_access_dialog branch February 28, 2020 03:17
@bsclifton
Copy link
Member

perfect - thanks for merging 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow up to #2710 - typo in dialog box
3 participants