-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show dialog when Brave tries to import Safari data w/o disk permission (uplift to 1.6.x) #4730
Conversation
Waiting for an answer re: #4530 (comment). |
Waiting for brave/brave-browser#8447 to be fixed before uplifting. CCing @rebron @bsclifton |
@kjozwiak text updated; CI running now 👍 |
Going to restart |
Waiting on #4530 (comment). |
Fixed wording on Safari import dialog
Text updated to remove |
Waiting for a new Nightly so we can check the new changes re: removing |
Nightly available with the above fix via https://github.com/brave/brave-browser/releases/tag/v1.7.39. Removing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uplift into 1.6.x
approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins
and CI/Travis
passed without any issues after several restarts. QA has also run through the PR on Nightly via #4530 (comment) and #4530 (comment).
Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.
Uplift of #4530
Fixes brave/brave-browser#2710
Approved, please ensure that before merging:
After you merge: