Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes ad conversion detection fails if the target URL of the last shown ad matches the conversion URL pattern - 1.6.x #4718

Closed
wants to merge 1 commit into from
Closed

Fixes ad conversion detection fails if the target URL of the last shown ad matches the conversion URL pattern - 1.6.x #4718

wants to merge 1 commit into from

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Feb 22, 2020 •
edited
Loading

Uplift of #4717
Resolves brave/brave-browser#8362

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey added this to the 1.6.x - Dev milestone Feb 22, 2020
@tmancey tmancey requested a review from a team February 22, 2020 00:46
@tmancey tmancey self-assigned this Feb 22, 2020
@tmancey tmancey changed the title Fixes ad conversion detection fails if the target URL of the last sho… Fixes ad conversion detection fails if the target URL of the last shown ad matches the conversion URL pattern - 1.6.x Feb 22, 2020
@tmancey tmancey force-pushed the issues/8362-1.6.x branch 2 times, most recently from 6e00b54 to dd484dc Compare February 26, 2020 16:37
@LaurenWags LaurenWags mentioned this pull request Mar 4, 2020
Closed
@bbondy bbondy modified the milestones: 1.6.x - Beta, 1.7.x - Dev Mar 10, 2020
@bsclifton
Copy link
Member

Closing as we don't have 1.6 anymore

@bsclifton bsclifton closed this Mar 11, 2020
@bsclifton bsclifton deleted the issues/8362-1.6.x branch March 11, 2020 22:10
@bsclifton bsclifton removed this from the 1.7.x - Beta milestone Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tmancey tmancey

Labels
bug feature/ads PR/Pending Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmancey @bsclifton @bbondy