Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes a dozen patches in favour of chromium_src override #468

Merged
merged 11 commits into from
Sep 19, 2018
Merged

Removes a dozen patches in favour of chromium_src override #468

merged 11 commits into from
Sep 19, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Sep 18, 2018

Fix brave/brave-browser#1173

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

bbondy added 11 commits September 17, 2018 23:53
@bbondy
Remove patch for chrome/app/chrome_command_ids.h
025b4dd
@bbondy
Remove patch for chrome/app/chrome_main.cc
8985c43
@bbondy
Remove patch for chrome/browser/browser_process_impl.cc
c53db9d
@bbondy
Remove patch for chrome/browser/io_thread.cc
b2decc6
@bbondy
Remove patch for chrome/browser/ui/browser.cc
91efb86
@bbondy
Remove patch for chrome/browser/extensions/extension_service.cc
3a0d49a
@bbondy
Remove patch for chrome/browser/ui/app_list/search/omnibox_provider.cc
d27b61d
@bbondy
Remove patch for components/omnibox/browser/omnibox_controller.cc
2d71075
@bbondy
Remove patch for chrome/browser/ui/webui/omnibox/omnibox_page_handler.cc
00b745a
@bbondy
Remove patch for chrome/browser/autocomplete/autocomplete_classifier_…
e75c58d 
…factory.cc
@bbondy
Remove patches we don't use for BraveAutocompleteController
a732007 
chrome/browser/android/omnibox/autocomplete_controller_android.cc for now
chrome/browser/ui/views/frame/test_with_browser_view.cc for now
@bbondy bbondy self-assigned this Sep 18, 2018
@bbondy bbondy requested a review from emerick September 18, 2018 15:57
emerick
emerick approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@yrliou yrliou merged commit 1e85e5d into master Sep 19, 2018
yrliou added a commit that referenced this pull request Sep 19, 2018
@yrliou
Merge pull request #468 from brave/patch-cleanup
4643192 
Removes a dozen patches in favour of chromium_src override
@yrliou
Copy link
Member

yrliou commented Sep 19, 2018

master: 1e85e5d
0.55.x: 4643192

@bsclifton bsclifton deleted the patch-cleanup branch September 26, 2018 05:43
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release
Development

Successfully merging this pull request may close these issues.

Cleanup low hanging fruit patching which we can do without patching
3 participants
@bbondy @yrliou @emerick