Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy cookie_rules_ because if anything uses PostTask it could be modi... #4653

Merged
merged 2 commits into from
Jun 16, 2020

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Feb 14, 2020

…fied during the iteration

possible fix for brave/brave-browser#8244
and brave/brave-browser#10297

Resolves

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bridiver bridiver self-assigned this Feb 14, 2020
@bridiver
Copy link
Collaborator Author

unrelated CI error - No such DSL method 'auditDepsWindows' found among steps

@bridiver bridiver added this to the 1.12.x - Nightly milestone Jun 16, 2020
@bridiver bridiver merged commit bbd64f0 into master Jun 16, 2020
@bridiver bridiver deleted the issues/8244 branch June 16, 2020 18:42
@bsclifton bsclifton changed the title Copy cookie_rules_ because if anything uses PostTask it could be modi… Copy cookie_rules_ because if anything uses PostTask it could be modi... Jun 16, 2020
brave-builds pushed a commit that referenced this pull request Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants