Handle shields settings properly #4624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhong
force-pushed
the
handle_shields_settings_properly
branch
from
60e66b1 to
d8a2e28
Compare
simonhong
force-pushed
the
handle_shields_settings_properly
branch
from
b1ab49c to
a98fde1
Compare
|
Kindly ping to reviewers :) |
yrliou
reviewed
Feb 14, 2020
patches/chrome-browser-browsing_data-chrome_browsing_data_remover_delegate.cc.patch
Outdated
Show resolved
Hide resolved
patches/components-content_settings-core-browser-host_content_settings_map.h.patch
Outdated
Show resolved
Hide resolved
simonhong
force-pushed
the
handle_shields_settings_properly
branch
from
a98fde1 to
a8042f4
Compare
simonhong
force-pushed
the
handle_shields_settings_properly
branch
2 times, most recently
from
fc8751f to
bc989ef
Compare
yrliou
reviewed
Feb 18, 2020
chromium_src/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_factory.cc
Outdated
Show resolved
Hide resolved
yrliou
reviewed
Feb 18, 2020
chromium_src/chrome/browser/browsing_data/counters/browsing_data_counter_factory.cc
Outdated
Show resolved
Hide resolved
yrliou
reviewed
Feb 18, 2020
chromium_src/chrome/browser/content_settings/host_content_settings_map_factory.cc
Outdated
Show resolved
Hide resolved
yrliou
approved these changes
Feb 18, 2020
simonhong
force-pushed
the
handle_shields_settings_properly
branch
from
bc989ef to
e551824
Compare
|
Kindly ping to code owners @bridiver :) |
bridiver
approved these changes
Feb 20, 2020
Site Settings also includes shields settings. So, "Site and Shields Settings" is more proper option name.
So far, shields settings are also cleard with "All time" time range. With "All time" range option, browser nuke whole plugins type data. With non "All time" range option, browser only clears plugins type for empty resource ids which is flash type. This commit makes browser clear shields data also with non "All time" range.
We don't need to subclass HostContentsSettingsMap to clear shields settings. BraveBrowsingDataRemoverDelegateTest is added.
simonhong
force-pushed
the
handle_shields_settings_properly
branch
from
e551824 to
294b7c1
Compare
simonhong
added
CI/skip-ios
|
Nice job with this! 😎👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR,
Site Settingsis renamed toSite and Shields Settings.and shields settings are also cleared via clear browsing data dialog with all time range option.
So far, it is cleared with
All timetime range because browser clears whole plugin type data with this time range. With the specific time range, browser only clears with empty resource id(flash type).and site counts properly calculated with
BraveSiteSettingsCounter.SiteSettingsCounteronly counts flash resource from plugin type.fix brave/brave-browser#8231
fix brave/brave-browser#8826
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
npm run test brave_unit_tests -- --filter=BraveSiteSettingsCounterTest*npm run test brave_unit_tests -- --filter= BraveBrowsingDataRemoverDelegateTest*See reproduce step in the issue
Reviewer Checklist:
After-merge Checklist:
changes has landed on.