Fixes missing Skip button on YouTube #4603
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanbr
changed the title
ryanbr
changed the title
|
Hmm my github title linking foo is weak. |
This was referenced Feb 12, 2020
|
@ryanbr now that we've merged cosmetic filtering, is this still needed? Updated title to be more descriptive and fixed link to issue 😄 |
bsclifton
changed the title
|
Should I create a new PR to remove the custom stylesheets in /assets? @bsclifton |
|
@ryanbr sorry for the super long turn-around in responding here (doh- my bad) I think now that cosmetic filters has landed, we can remove all of them, right? That would definitely be preferable if these items are already being included in the cosmetic filter list 😄 |
|
Okay, will submit a new PR removing all the cosmetics. |
3 tasks
|
Closing in favor of #4916 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#8209
Working with @LaurenWags It was reported Youtube ad skip this was still causing issues, found an older filter
.video-adswas the main cause of this.I was partially right on my previous commit #4403 with
##.ytp-ad-modulebut missed the previous.video-adsfiller in the removeEmptyElements list. The full element we're incorrectly blocking:youtube.com##.ytp-ad-module.video-adsTo be sure this was resolved, I manually loaded our stylesheet.
Elements being loaded:
Element: .video-ads overlay:
Can we get this into 1.4? @bsclifton