Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Chromium 70.0.3538.16 #452

Merged
merged 5 commits into from
Sep 17, 2018
Merged

Upgrade to Chromium 70.0.3538.16 #452

merged 5 commits into from
Sep 17, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Sep 14, 2018

Please review but don't merge yet, I'm still running builds and tests.

Fix brave/brave-browser#1130

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bbondy bbondy self-assigned this Sep 14, 2018
@bbondy bbondy requested a review from darkdh September 14, 2018 20:10
darkdh
darkdh previously approved these changes Sep 14, 2018
View reviewed changes
@yrliou
Run UpgradeToTLSCallback in ~TLSClientSocket
bd913ee 
TLSClientSocket could be destroyed if the client's request is cancelled.
The pending connect_callback_(UpgradeToTLSCallback) need to be run before
TLSClientSocket is destroyed to avoid DCHECK(!connected) error in
tcp_socket.mojom.cc.
@bbondy
Copy link
Member Author

bbondy commented Sep 17, 2018

++ on Jocelyn's last commit.

@bbondy bbondy merged commit 8f47af1 into master Sep 17, 2018
emerick pushed a commit that referenced this pull request Sep 17, 2018
@bbondy @emerick
Merge pull request #452 from brave/70.0.3538.16
8c79aa5 
Upgrade to Chromium 70.0.3538.16
@emerick
Copy link
Contributor

emerick commented Sep 17, 2018 •
edited
Loading

master: 8f47af1
0.55.x: 8c79aa5

@bsclifton bsclifton deleted the 70.0.3538.16 branch September 26, 2018 05:44
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkdh darkdh darkdh left review comments

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release
Development

Successfully merging this pull request may close these issues.

Upgrade to 70.0.3538.16
4 participants
@bbondy @emerick @darkdh @yrliou