Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed contribution queue not being deleted (1.4.x) #4353

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jan 9, 2020

Resolves brave/brave-browser#7579

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.4.x - Dev milestone Jan 9, 2020
@NejcZdovc NejcZdovc requested a review from a team January 9, 2020 23:46
@NejcZdovc NejcZdovc self-assigned this Jan 9, 2020
@NejcZdovc NejcZdovc changed the title Fixed contribution queue not being deleted Fixed contribution queue not being deleted (1.4.x) Jan 9, 2020
@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Jan 10, 2020
@kjozwiak
Copy link
Member

@kjozwiak
Copy link
Member

Looks like it failed again in the same spot on macOS as per https://ci.brave.com/job/brave-browser-build-pr/job/contribution-queue-1.4/4/execution/node/331/log/:

22:27:36  Operation completed over 22 objects/138.4 MiB.                                   
22:28:27  Error: Command 'git ls-tree HEAD third_party/libgifcodec' returned non-zero exit status 128 in /Users/jenkins/jenkins/workspace/_build-pr_contribution-queue-1.4/src
22:28:27  error: object directory /Users/jenkins/cache/chromium.googlesource.com-chromium-src/objects does not exist; check .git/objects/info/alternates.
22:28:27  fatal: not a tree object

Going to restart once more.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.4.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed after several restarts on macOS. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit b754e72 into 1.4.x Jan 10, 2020
@kjozwiak kjozwiak deleted the contribution-queue-1.4 branch January 10, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants