Enable DNS-over-HTTPS upgrades when possible #4314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#1864.
This will not change a user's DNS provider. Instead, we will only upgrade to DoH if the OS resolver is known to support DoH (e.g. Cloudflare or Google).
This essentially enables for all users the DoH experiment that Chrome rolled out to 1% of its users: https://docs.google.com/document/d/15Ss0OaJeb-T3g2RMwgikHvsC0CPKd-MLeGeetv1wYY4/edit#
Security review: https://github.com/brave/security/issues/57
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
On Windows configure the browser:
You should see:
On macOS configure the browser:
You should see:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.