Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable DNS-over-HTTPS upgrades when possible #4314

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Jan 7, 2020

Fixes brave/brave-browser#1864.

This will not change a user's DNS provider. Instead, we will only upgrade to DoH if the OS resolver is known to support DoH (e.g. Cloudflare or Google).

This essentially enables for all users the DoH experiment that Chrome rolled out to 1% of its users: https://docs.google.com/document/d/15Ss0OaJeb-T3g2RMwgikHvsC0CPKd-MLeGeetv1wYY4/edit#

Security review: https://github.com/brave/security/issues/57

Submitter Checklist:

Test Plan:

On Windows configure the browser:

  1. Click on the Start menu, then click on Control Panel.
  2. Click on Network and Internet.
  3. Click on Change Adapter Settings.
  4. Right click on the network adapter you are using.
  5. Select Internet Protocol Version 4
  6. Click Properties.
  7. Click Use The Following DNS Server Addresses.
  8. Replace those addresses with the 1.1.1.1 DNS addresses: 1.1.1.1 and 1.0.0.1
  9. Save the settings.
  10. Right-click on the adapter and then click "Disable".
  11. Right-click on the adapter and then click "Enable".
  12. Start Brave and visit https://1.1.1.1/help.

You should see:

  • Connected to 1.1.1.1: Yes
  • Using DNS over HTTPS (DoH): Yes

On macOS configure the browser:

Screen Shot 2020-03-24 at 1 54 40 PM

You should see:

  • Connected to 1.1.1.1: Yes
  • Using DNS over HTTPS (DoH): Yes

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@fmarier fmarier added this to the 1.5.x - Nightly milestone Jan 7, 2020
@fmarier fmarier requested a review from jumde January 7, 2020 00:18
@fmarier fmarier self-assigned this Jan 7, 2020
@fmarier fmarier force-pushed the enable-doh-upgrades-1864 branch from d33f438 to 859eddd Compare January 7, 2020 01:06
@fmarier fmarier removed the request for review from jumde January 7, 2020 19:35
@fmarier fmarier force-pushed the enable-doh-upgrades-1864 branch from 859eddd to d23a6db Compare January 17, 2020 19:44
@fmarier fmarier requested a review from jumde January 17, 2020 19:45
@fmarier fmarier force-pushed the enable-doh-upgrades-1864 branch 2 times, most recently from e64b206 to ac1ba50 Compare February 10, 2020 19:58
…er#1864)

This will not change a user's DNS provider. Instead, we will only
upgrade to DoH if the OS resolver is known to support DoH (e.g.
Cloudflare or Google).

This essentially enables for all users the DoH experiment that
Chrome rolled out to 1% of its users:

https://docs.google.com/document/d/15Ss0OaJeb-T3g2RMwgikHvsC0CPKd-MLeGeetv1wYY4/edit#
@fmarier fmarier force-pushed the enable-doh-upgrades-1864 branch from ac1ba50 to d2e8989 Compare February 11, 2020 01:47
@fmarier fmarier merged commit 2343887 into master Feb 11, 2020
@fmarier fmarier deleted the enable-doh-upgrades-1864 branch February 11, 2020 22:04
@bsclifton
Copy link
Member

Updated milestone to be 1.6 (I think master was 1.5 when this was opened) and also added milestone to brave/brave-browser#1864
cc: @fmarier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNS over HTTPS
4 participants